rickyma commented on code in PR #1897:
URL:
https://github.com/apache/incubator-uniffle/pull/1897#discussion_r1686773640
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -179,15 +184,19 @@ public void nodesCheckTest() {
nodesCheck();
}
- private void updateExcludeNodes(String path) {
+ private synchronized void updateExcludeNodes(String path) {
Review Comment:
ditto, also other places too
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -84,6 +89,7 @@ public class SimpleClusterManager implements ClusterManager {
private boolean startupSilentPeriodEnabled;
private long startupSilentPeriodDurationMs;
private boolean readyForServe = false;
+ private String excludeNodesPath;
Review Comment:
ditto
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/ClusterManager.java:
##########
@@ -81,4 +81,6 @@ public interface ClusterManager extends Closeable {
void decommission(String serverId);
void cancelDecommission(String serverId);
+
+ boolean addExcludeNodes(List<String> excludeNodeIds);
Review Comment:
addExcludeNodes
->
addExcludedNodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
