maobaolong commented on code in PR #1937:
URL:
https://github.com/apache/incubator-uniffle/pull/1937#discussion_r1687536027
##########
bin/start-shuffle-server.sh:
##########
@@ -30,7 +30,8 @@ SHUFFLE_SERVER_CONF_FILE="${RSS_CONF_DIR}/server.conf"
JAR_DIR="${RSS_HOME}/jars"
LOG_CONF_FILE="${RSS_CONF_DIR}/log4j2.xml"
LOG_PATH="${RSS_LOG_DIR}/shuffle_server.log"
-AUDIT_LOG_PATH="${RSS_LOG_DIR}/audit.log"
+SHUFFLE_SERVER_STORAGE_AUDIT_LOG_PATH="${RSS_LOG_DIR}/shuffle_server_storage_audit.log"
Review Comment:
Discussed with @rickyma , The scripts of `uniffle` could do some refactor to
abstract configure purpose vars into `rss-env.sh`, then put `rss-env.sh` into
`conf` folder, eventually, we can maintain scripts by git repository and
maintain conf by conf servers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
