rickyma commented on code in PR #1960:
URL: 
https://github.com/apache/incubator-uniffle/pull/1960#discussion_r1691550420


##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssShuffleHandle.java:
##########
@@ -28,6 +28,7 @@
 import org.apache.uniffle.common.ShuffleServerInfo;
 
 public class RssShuffleHandle<K, V, C> extends ShuffleHandle {
+  private static final long serialVersionUID = -5519528926859572710L;

Review Comment:
   I think we need to define this to `0L` like what Spark does currently. 
   
   > Zero means "compute the version id at runtime by applying the standard 
algorithm" based on the actual class that you are serializing / deserializing. 
That means that whenever your code's effective serialization signature changes, 
the serialization / deserialization code will use a different version id
   
   Refer to https://stackoverflow.com/a/21851309/9217742.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to