maobaolong commented on code in PR #1965: URL: https://github.com/apache/incubator-uniffle/pull/1965#discussion_r1692561026
########## conf/local_dev/dashboard.conf: ########## @@ -17,4 +17,4 @@ rss.dashboard.http.port 19997 # change to the actual coordinator web addresses -coordinator.web.address http://localhost:19998,http://localhost:19998 +coordinator.web.address http://127.0.0.1:19998,http://localhost:19999 Review Comment: You can move this conf into a place out of git version control? ########## dashboard/src/main/java/org/apache/uniffle/dashboard/web/proxy/WebProxyServlet.java: ########## @@ -22,16 +22,22 @@ import javax.servlet.http.HttpServletResponse; import com.google.common.base.Preconditions; -import org.eclipse.jetty.client.api.Request; -import org.eclipse.jetty.client.api.Response; +import org.eclipse.jetty.http.HttpStatus; import org.eclipse.jetty.proxy.ProxyServlet; import org.slf4j.Logger; import org.slf4j.LoggerFactory; public class WebProxyServlet extends ProxyServlet { private static final Logger LOG = LoggerFactory.getLogger(WebProxyServlet.class); + /** The key of the request header. */ + private static final String TARGETADDRESS = "targetAddress"; Review Comment: TARGETADDRESS -> `HEADER_TARGET_ADDRESS ` would be better ########## dashboard/src/main/java/org/apache/uniffle/dashboard/web/proxy/WebProxyServlet.java: ########## @@ -22,16 +22,22 @@ import javax.servlet.http.HttpServletResponse; import com.google.common.base.Preconditions; -import org.eclipse.jetty.client.api.Request; -import org.eclipse.jetty.client.api.Response; +import org.eclipse.jetty.http.HttpStatus; import org.eclipse.jetty.proxy.ProxyServlet; import org.slf4j.Logger; import org.slf4j.LoggerFactory; public class WebProxyServlet extends ProxyServlet { private static final Logger LOG = LoggerFactory.getLogger(WebProxyServlet.class); + /** The key of the request header. */ + private static final String TARGETADDRESS = "targetAddress"; + private static final String REQUESTSERVERTYPE = "requestServerType"; Review Comment: The same `REQUESTSERVERTYPE ` -> `HEADER_REQUEST_SERVER_TYPE` ########## dashboard/src/main/java/org/apache/uniffle/dashboard/web/proxy/WebProxyServlet.java: ########## @@ -22,16 +22,22 @@ import javax.servlet.http.HttpServletResponse; import com.google.common.base.Preconditions; -import org.eclipse.jetty.client.api.Request; -import org.eclipse.jetty.client.api.Response; +import org.eclipse.jetty.http.HttpStatus; import org.eclipse.jetty.proxy.ProxyServlet; import org.slf4j.Logger; import org.slf4j.LoggerFactory; public class WebProxyServlet extends ProxyServlet { private static final Logger LOG = LoggerFactory.getLogger(WebProxyServlet.class); + /** The key of the request header. */ + private static final String TARGETADDRESS = "targetAddress"; + private static final String REQUESTSERVERTYPE = "requestServerType"; + /** The value of the request header. */ + private static final String COORDINATOR = "coordinator"; + + private static final String SERVER = "server"; Review Comment: REQUEST_SERVER_TYPE_SERVER ########## dashboard/src/main/java/org/apache/uniffle/dashboard/web/proxy/WebProxyServlet.java: ########## @@ -22,16 +22,22 @@ import javax.servlet.http.HttpServletResponse; import com.google.common.base.Preconditions; -import org.eclipse.jetty.client.api.Request; -import org.eclipse.jetty.client.api.Response; +import org.eclipse.jetty.http.HttpStatus; import org.eclipse.jetty.proxy.ProxyServlet; import org.slf4j.Logger; import org.slf4j.LoggerFactory; public class WebProxyServlet extends ProxyServlet { private static final Logger LOG = LoggerFactory.getLogger(WebProxyServlet.class); + /** The key of the request header. */ + private static final String TARGETADDRESS = "targetAddress"; + private static final String REQUESTSERVERTYPE = "requestServerType"; + /** The value of the request header. */ + private static final String COORDINATOR = "coordinator"; Review Comment: REQUEST_SERVER_TYPE_COORDINATOR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
