xianjingfeng commented on PR #1983: URL: https://github.com/apache/incubator-uniffle/pull/1983#issuecomment-2259772890
> I don't think you should update the mvnw script. You should update the pom.xml in this repo or like @summaryzb suggested, compile uniffle with corresponding mvn options in gluten. 1. When using JDK8, compiling with `maven.compiler.release` will fail, so i think it not a good idea to update the pom.xml. 2. Compile uniffle with corresponding mvn options in gluten is not friendly to gluten users. If the users need to compile the Uniffle source code by himself, there is no need to publish the client package to the Maven repository. 3. If it influence the performance of the code, i think we can just update `publish_maven_artifacts.sh` @advancedxy @summaryzb @jerqi @kaijchen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
