rickyma commented on code in PR #1889: URL: https://github.com/apache/incubator-uniffle/pull/1889#discussion_r1703584705
########## docs/server_guide.md: ########## @@ -145,7 +145,9 @@ For HADOOP FS, the conf value of `rss.server.single.buffer.flush.threshold` shou Finally, to improve the speed of writing to HDFS for a single partition, the value of `rss.server.max.concurrency.of.per-partition.write` and `rss.server.flush.hdfs.threadPool.size` could be increased to 50 or 100. #### Hard limit -Once the huge partition reach the hard limit size, the conf is `rss.server.huge-partition.size.hard.limit`, server reject the sendShuffleData request and do not retry for client, so that client can fail fast and user can modify their sql or job to avoid the reach the partition hard limit. +Once the huge partition reaches the hard limit size, which is set by the configuration `rss.server.huge-partition.size.hard.limit`, the server will reject the `sendShuffleData` request and the client will not retry. This allows the client to fail fast and enables the user to modify their SQLs or jobs to avoid reaching the partition hard limit. + +For example, if the hard limit is set to 50g, the server will reject the request if the partition size is greater than 50g, causing the job to eventually fail. E.g. If the hard limit is set to `50g`, the server will reject the request if the partition size is greater than 50g, and the job will fail eventually. Review Comment: This line should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
