advancedxy commented on code in PR #1983: URL: https://github.com/apache/incubator-uniffle/pull/1983#discussion_r1706700443
########## pom.xml: ########## @@ -1213,6 +1213,16 @@ </reporting> <profiles> + <profile> + <id>set-compiler-release</id> + <activation> + <jdk>[9,)</jdk> + </activation> + <properties> + <maven.compiler.release>8</maven.compiler.release> Review Comment: What if users want to build Uniffle with higher JDK and release with higher jdk versions? Is it possible for them to run mvn with something like below? ``` ./mvnw -Dmaven.compiler.release=11 ``` If so, you should update the README.md about the `Building Uniffle` section as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
