xumanbu opened a new pull request, #2047:
URL: https://github.com/apache/incubator-uniffle/pull/2047
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
The RssClientConf#RSS_CLIENT_TYPE is used for creating ShuffleReaderClient
and ShuffleWriteClient, while the RssBaseConf#RSS_CLIENT_TYPE is for creating
CoordinatorClient in the ShuffleServer. This may cause confusion in the code.
Fix: #2046
### Does this PR introduce _any_ user-facing change?
YES.
### How was this patch tested?
NONEED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
