wForget commented on code in PR #2057:
URL: 
https://github.com/apache/incubator-uniffle/pull/2057#discussion_r1721175058


##########
common/src/main/java/org/apache/uniffle/common/compression/Codec.java:
##########
@@ -72,5 +74,6 @@ public enum Type {
     ZSTD,
     NOOP,

Review Comment:
   > Codec.decompress requires a new buffer, which is not necessary for non 
compression.
   
   As commented above, this seems unavoidable. Should we care about this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to