xianjingfeng commented on code in PR #2067:
URL:
https://github.com/apache/incubator-uniffle/pull/2067#discussion_r1722826590
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/MultiReplicaClientReadHandler.java:
##########
@@ -49,7 +51,9 @@ public MultiReplicaClientReadHandler(
this.handlers = handlers;
this.blockIdBitmap = blockIdBitmap;
this.processedBlockIds = processedBlockIds;
- this.shuffleServerInfos = shuffleServerInfos;
+ List<ShuffleServerInfo> shuffledServerList = new
ArrayList<>(shuffleServerInfos);
+ Collections.shuffle(shuffledServerList);
Review Comment:
In most cases, the complete data can be read from the first shuffle server.
But the shuffle server with no data may be accessed first with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
