zuston commented on code in PR #2072:
URL:
https://github.com/apache/incubator-uniffle/pull/2072#discussion_r1726904750
##########
common/src/main/java/org/apache/uniffle/common/compression/NoOpCodec.java:
##########
@@ -31,9 +31,9 @@ public static NoOpCodec getInstance() {
@Override
public void decompress(ByteBuffer src, int uncompressedLen, ByteBuffer dest,
int destOffset) {
- dest.put(src);
dest.position(destOffset);
- dest.limit(destOffset + uncompressedLen);
+ dest.put(src.duplicate());
+ dest.rewind();
Review Comment:
rewind will make the offset reset to 0. I think this is OK for the
destOffset is 0, in other cases, let me think twice. Could you give me some
other examples if you know this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
