xianjingfeng commented on code in PR #2074:
URL:
https://github.com/apache/incubator-uniffle/pull/2074#discussion_r1728151822
##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -169,7 +170,14 @@ public void processFlushEvent(ShuffleDataFlushEvent event)
throws Exception {
storageDataReplica,
user,
maxConcurrencyPerPartitionToWrite);
- ShuffleWriteHandler handler = storage.getOrCreateWriteHandler(request);
+ ShuffleWriteHandler handler;
+ try {
+ handler = storage.getOrCreateWriteHandler(request);
Review Comment:
> If there is no write permission, the retry will overcome this case? Or
just retry again to write this disk
It dependency the logic of `StorageManagerSelector`. If EventRetryException
be catch in
`org.apache.uniffle.server.DefaultFlushEventHandler#handleEventAndUpdateMetrics`,
the retryTimes of the flush event will be increase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
