advancedxy commented on code in PR #2089:
URL:
https://github.com/apache/incubator-uniffle/pull/2089#discussion_r1736225710
##########
deploy/kubernetes/operator/pkg/webhook/manager.go:
##########
@@ -69,8 +69,11 @@ func newAdmissionManager(cfg *config.Config)
*admissionManager {
} else {
am.loadCertsFromSecret()
}
+
+ klog.Infof("enable leader election: %v", cfg.LeaderElection)
Review Comment:
Nit: the first word enable seems to indicate the leader election is enabled.
I would suggest to change it to something like the following:
```suggestion
klog.Infof("leader election enabled?: %v", cfg.LeaderElection)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
