xianjingfeng commented on PR #2091: URL: https://github.com/apache/incubator-uniffle/pull/2091#issuecomment-2323924808
> Do you think `Collections.synchronizedList` could be better? It not thread-safe when iterating over it. @maobaolong > Why not using the `synchronized` to ensure the safety of race condition ? For the job that finally runs successfully, there is at most one element in the list, so I think this performance impact is acceptable. If you use `synchronized`, we need to pay attention to thread-safe issues when maintaining this part of the code later. `synchronized` is ok for me too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
