zuston commented on code in PR #2104:
URL:
https://github.com/apache/incubator-uniffle/pull/2104#discussion_r1751483271
##########
common/src/main/java/org/apache/uniffle/common/util/ByteBufUtils.java:
##########
@@ -80,10 +80,10 @@ public static final ByteBuf readSlice(ByteBuf from) {
return from.retain().readSlice(length);
}
- public static final byte[] readBytes(ByteBuf buf) {
+ public static final byte[] readBytes(ByteBuf byteBuf) {
+ ByteBuf buf = byteBuf.duplicate();
Review Comment:
The duplicate just is a reference count that is low cost, anyway this is a
good improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
