zuston commented on code in PR #2115:
URL:
https://github.com/apache/incubator-uniffle/pull/2115#discussion_r1764705296
##########
storage/src/main/java/org/apache/uniffle/storage/common/AbstractStorage.java:
##########
@@ -40,17 +41,22 @@ public abstract class AbstractStorage implements Storage {
abstract ShuffleWriteHandler
newWriteHandler(CreateShuffleWriteHandlerRequest request);
@Override
- public ShuffleWriteHandler
getOrCreateWriteHandler(CreateShuffleWriteHandlerRequest request) {
+ public Pair<ShuffleWriteHandler, Boolean> getOrCreateWriteHandler(
Review Comment:
I don't hope to change the original abstract definition, this pair returning
structure looks tricky.
From my sight, why not making the is_created or is_cached as the internal
var into the concreted ShuffleWriteHandler, and then expose this as a interface
method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
