maobaolong commented on code in PR #2121:
URL:
https://github.com/apache/incubator-uniffle/pull/2121#discussion_r1764778544
##########
common/src/test/java/org/apache/uniffle/common/ReconfigurableConfManagerTest.java:
##########
@@ -71,6 +71,8 @@ public void test() throws InterruptedException {
.until(() -> portReconfigurable.get().equals(100));
assertEquals(200, rpcReconfigurable.get());
assertEquals(Arrays.asList("/d1"), typeReconfigurable.get());
+ // The base config should be updated too
+ assertEquals(200, base.getInteger(RPC_SERVER_PORT));
Review Comment:
@zuston Do you think this is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
