maobaolong commented on code in PR #2131:
URL:
https://github.com/apache/incubator-uniffle/pull/2131#discussion_r1767818963
##########
server/src/main/java/org/apache/uniffle/server/HugePartitionUtils.java:
##########
@@ -130,11 +131,9 @@ public static boolean limitHugePartition(
int partitionId,
Review Comment:
There are an issue about the caller of this method which is
`ShuffleTaskManager#requireBuffer`, it through
`NoBufferForHugePartitionException` while one of `partitionIds` exceed the huge
partition limit, it is too `Coarse-Grained`. Just motion it here, do not mind
it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
