zhengchenyu commented on PR #2058: URL: https://github.com/apache/incubator-uniffle/pull/2058#issuecomment-2370321471
> > > > > > > I'm OK with this PR. But it's meaningless. When an OOM error occurs, this PR will not help much. > > > > > > > > > > > > > > > > > > This PR is not to prevent the OOM exception, but to ensure that the pre-allocated ByteBuf can be released normally. > > > > > > > > > > > > > > > You shouldn't catch OOM exception. If it throws OOM, more errors may throw. You can't recover it by just catching it. > > > > > > > > > > > > I don't understand what you mean. If the OOM exception happen, how we deal with the pre-allocated ByteBuf ? Reconfigure and restart the server , or other ways? > > > > > > > > > If it will OOM, the java process should exit. > > > > > > This OOM is not java OOM. The OOM is that the direct memory used exceeds the direct memory limit of Netty. If Netty's direct memory limit is too low, it will easily trigger io.netty.util.internal.OutOfDirectMemoryError without causing java process exit. > > Is `io.netty.util.internal.OutOfDirectMemoryError ` a subclass of `OutOfMemoryError`? It's a little weird to catch an error. Because we can't recover an error usually. `io.netty.util.internal.OutOfDirectMemoryError ` is not a subclass of `OutOfMemoryError`. Even though it's a little weird to catch an error, but this error can not make the process exit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
