maobaolong commented on code in PR #2138:
URL:
https://github.com/apache/incubator-uniffle/pull/2138#discussion_r1774279735
##########
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/RssShuffleManagerBase.java:
##########
@@ -947,23 +947,23 @@ protected Map<Integer, List<ShuffleServerInfo>>
requestShuffleAssignment(
int retryTimes =
sparkConf.get(RssSparkConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES);
faultyServerIds.addAll(rssStageResubmitManager.getServerIdBlackList());
try {
- ShuffleAssignmentsInfo response =
- shuffleWriteClient.getShuffleAssignments(
- appId,
- shuffleId,
- partitionNum,
- partitionNumPerRange,
- assignmentTags,
- assignmentShuffleServerNumber,
- estimateTaskConcurrency,
- faultyServerIds,
- stageId,
- stageAttemptNumber,
- reassign,
- retryInterval,
- retryTimes);
return RetryUtils.retry(
() -> {
+ ShuffleAssignmentsInfo response =
Review Comment:
How about add a simple comment here to explain why the retryInterval and
retryTimes are `0` here, so that reviewer and other developer can understand
the motivation of this change.
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/CoordinatorGrpcRetryableClient.java:
##########
@@ -85,7 +85,7 @@ public void sendAppHeartBeat(RssAppHeartBeatRequest request,
long timeoutMs) {
"send heartbeat to coordinator");
}
- public void registerApplicationInfo(RssApplicationInfoRequest request, long
timeoutMs) {
+ public void registerApplicationInfo(RssApplicationInfoRequest request) {
Review Comment:
As nearly all of the API of this class are similar with `CoordinatorClient`,
how about forward further to let this class `implements CoordinatorClient`,
then `CoordinatorClientFactory#createCoordinatorClient` can create one of the
concrete implementation within `CoordinatorGrpcRetryableClient` or others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
