maobaolong commented on code in PR #2143:
URL:
https://github.com/apache/incubator-uniffle/pull/2143#discussion_r1776427014
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/MultiReplicaClientReadHandler.java:
##########
@@ -76,10 +76,22 @@ public ShuffleDataResult readShuffleData() {
RssUtils.checkProcessedBlockIds(blockIdBitmap, processedBlockIds);
return result;
} catch (RssException e) {
- LOG.warn(
- "Finished read from [{}], but haven't finished read all the
blocks.",
- shuffleServerInfos.get(readHandlerIndex).getId(),
- e);
+ // If this is not the last server, then read next.
+ if (readHandlerIndex < handlers.size() - 1) {
+ LOG.info(
+ "Finished read from {}/{} [{}], haven't finished read all the
blocks. Will read from next server {}",
+ readHandlerIndex + 1,
+ handlers.size(),
+ shuffleServerInfos.get(readHandlerIndex).getId(),
+ shuffleServerInfos.get(readHandlerIndex + 1).getId());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
