zuston commented on code in PR #2144:
URL:
https://github.com/apache/incubator-uniffle/pull/2144#discussion_r1776446912
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -1241,7 +1241,8 @@ public void getLocalShuffleIndex(
reply = builder.build();
} catch (FileNotFoundException indexFileNotFoundException) {
LOG.warn(
- "Index file for {} is not found, maybe the data has been flushed
to cold storage.",
+ "Index file for {} is not found, maybe the data has been flushed
to cold storage "
+ + "or still in memory buffer pool.",
Review Comment:
Got it, thanks for your explanation. BTW, the another read headler for
partition spilt should be introduced to avoid too much unnecessary request.
Anyway, current impl is OK for this case, let's optimize this in the later days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
