zhengchenyu opened a new issue, #2165:
URL: https://github.com/apache/incubator-uniffle/issues/2165

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Describe the bug
   
   Tez task throw exception like this:
   
   ```
   2024-10-10 10:35:00,391 [ERROR] [AMShutdownThread] |app.RssDAGAppMaster|: 
Failed to release Rss resources.
   java.lang.IllegalArgumentException
           at 
java.util.concurrent.ThreadPoolExecutor.<init>(ThreadPoolExecutor.java:1314)
           at 
java.util.concurrent.ThreadPoolExecutor.<init>(ThreadPoolExecutor.java:1237)
           at 
java.util.concurrent.Executors.newFixedThreadPool(Executors.java:151)
           at 
org.apache.uniffle.common.util.ThreadUtils.getDaemonFixedThreadPool(ThreadUtils.java:79)
           at 
org.apache.uniffle.client.impl.ShuffleWriteClientImpl.unregisterShuffle(ShuffleWriteClientImpl.java:1036)
           at 
org.apache.tez.dag.app.TezRemoteShuffleManager.unregisterShuffle(TezRemoteShuffleManager.java:122)
           at 
org.apache.tez.dag.app.TezRemoteShuffleManager.shutdown(TezRemoteShuffleManager.java:115)
           at 
org.apache.tez.dag.app.RssDAGAppMaster.releaseRssResources(RssDAGAppMaster.java:307)
           at 
org.apache.tez.dag.app.RssDAGAppMaster.serviceStop(RssDAGAppMaster.java:283)
           at 
org.apache.hadoop.service.AbstractService.stop(AbstractService.java:220)
           at 
org.apache.tez.dag.app.DAGAppMaster$DAGAppMasterShutdownHandler$AMShutdownRunnable.run(DAGAppMaster.java:979)
           at java.lang.Thread.run(Thread.java:748)
   ```
   
   It is not critical bug. In fact, this bug did not cause any negative 
effects. In fact, there are two way to unregister shuffle:
   * (1) unregister shuffle by shuffle id
   * (2) unregister shuffle by app id
   (1) takes effect when stage or dag is completed. (2) take effect when app is 
finished.
   
   For tez app, when dag is completed, will call (1). When app is finished, 
will call (2). But when we call (2), all shuffleServerInfoMap have been removed 
when call (1), and the pool size of executorService is 0, then throw 
IllegalArgumentException.
   
   ### Affects Version(s)
   
   master
   
   ### Uniffle Server Log Output
   
   _No response_
   
   ### Uniffle Engine Log Output
   
   _No response_
   
   ### Uniffle Server Configurations
   
   _No response_
   
   ### Uniffle Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to