maobaolong commented on code in PR #2167:
URL:
https://github.com/apache/incubator-uniffle/pull/2167#discussion_r1796418935
##########
server/src/test/java/org/apache/uniffle/server/ShuffleServerMetricsTest.java:
##########
@@ -240,7 +242,9 @@ public void testNettyMetrics() throws Exception {
ObjectMapper mapper = new ObjectMapper();
JsonNode actualObj = mapper.readTree(content);
assertEquals(2, actualObj.size());
- assertEquals(68, actualObj.get("metrics").size());
+ // the original metrics have 69 items before this commit, but is would
grow up
+ // when the new metric is added, we needn't correct this test while adding
new metrics
+ assertTrue(actualObj.get("metrics").size() > 50);
Review Comment:
Ok, revert it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
