rickyma commented on code in PR #2058:
URL:
https://github.com/apache/incubator-uniffle/pull/2058#discussion_r1802525657
##########
common/src/main/java/org/apache/uniffle/common/netty/protocol/SendShuffleDataRequest.java:
##########
@@ -103,7 +103,19 @@ private static Map<Integer, List<ShuffleBlockInfo>>
decodePartitionData(ByteBuf
int lengthOfShuffleBlocks = byteBuf.readInt();
List<ShuffleBlockInfo> shuffleBlockInfoList = Lists.newArrayList();
for (int j = 0; j < lengthOfShuffleBlocks; j++) {
- shuffleBlockInfoList.add(Decoders.decodeShuffleBlockInfo(byteBuf));
+ try {
+ shuffleBlockInfoList.add(Decoders.decodeShuffleBlockInfo(byteBuf));
+ } catch (Throwable t) {
+ // An OutOfDirectMemoryError will be thrown, when the direct memory
reaches the limit.
+ // OutOfDirectMemoryError does not cause the jvm exit and cause the
direct memory leak.
+ // Warning: Please set DIRECT_MEMORY_LIMIT to a reasonable value.
Review Comment:
You can also put the link of the
[guidance](https://github.com/apache/incubator-uniffle/pull/1893) in the
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
