rickyma commented on code in PR #2058:
URL:
https://github.com/apache/incubator-uniffle/pull/2058#discussion_r1807247808
##########
common/src/main/java/org/apache/uniffle/common/netty/protocol/SendShuffleDataRequest.java:
##########
@@ -103,7 +103,21 @@ private static Map<Integer, List<ShuffleBlockInfo>>
decodePartitionData(ByteBuf
int lengthOfShuffleBlocks = byteBuf.readInt();
List<ShuffleBlockInfo> shuffleBlockInfoList = Lists.newArrayList();
for (int j = 0; j < lengthOfShuffleBlocks; j++) {
- shuffleBlockInfoList.add(Decoders.decodeShuffleBlockInfo(byteBuf));
+ try {
+ shuffleBlockInfoList.add(Decoders.decodeShuffleBlockInfo(byteBuf));
+ } catch (Throwable t) {
+ // An OutOfDirectMemoryError will be thrown, when the direct memory
reaches the limit.
+ // OutOfDirectMemoryError will not cause the JVM to exit, but may
lead to direct memory
+ // leaks.
+ // Warning: You can refer to docs/server_guide.md to set
MAX_DIRECT_MEMORY_SIZE to a
Review Comment:
It's not a warning.
Maybe: Warning: -> Note:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
