lwllvyb commented on code in PR #2182:
URL:
https://github.com/apache/incubator-uniffle/pull/2182#discussion_r1808247137
##########
server/src/main/java/org/apache/uniffle/server/netty/ShuffleServerNettyHandler.java:
##########
@@ -274,7 +273,7 @@ public void handleSendShuffleDataRequest(TransportClient
client, SendShuffleData
return;
}
final long start = System.currentTimeMillis();
- shuffleBufferManager.releaseMemory(req.encodedLength(), false, true);
+ shuffleBufferManager.releaseMemory(req.getDecodedLength(), false,
true);
Review Comment:
There already has a test class ```NettyProtocolTest``` to make sure that the
encodedLength sent from client is same as the getDecodedLength of the server
received.
Does we need a new test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
