lwllvyb commented on PR #2216: URL: https://github.com/apache/incubator-uniffle/pull/2216#issuecomment-2428143604
> Should this config option be same with the local? Maybe they should have different default value for better performance. Thanks for your suggestion. I am very agree with you that they will get better performance with different values for different storages. I will add different configs (```rss.storage.localfile.write.dataBufferSize```, ```rss.storage.hadoop.write.indexBufferSize```, ```rss.storage.hadoop.write.dataBufferSize```, ```rss.storage.hadoop.write.indexBufferSize```) for LOCALFILE and HADOOP. If we can set the default values to be the same (e.g. 8K ?), we can config different values to cope with different real cluster scenarios. Do you have any better suggestions on default values? Thanks again for taking the time to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
