zhengchenyu commented on code in PR #2202:
URL:
https://github.com/apache/incubator-uniffle/pull/2202#discussion_r1810037857
##########
common/src/main/java/org/apache/uniffle/common/serializer/writable/WritableSerializerInstance.java:
##########
@@ -47,19 +47,28 @@ public <T> T deserialize(DataInputBuffer buffer, Class
vClass) throws IOExceptio
}
@Override
- public <K, V> SerializationStream serializeStream(OutputStream output,
boolean raw) {
+ public <K, V> SerializationStream serializeStream(
+ SerOutputStream output, boolean raw, boolean shared) {
if (raw) {
- return new RawWritableSerializationStream(this, output);
+ if (shared) {
Review Comment:
> Could we give a better name for it?
In fact, I used to use `shallow` as name before. But I change to 'shared'.
Compare to `RawWritableDeserializationStream`,
`SharedRawWritableDeserializationStream` use shared buffer to store record, but
`RawWritableDeserializationStream` allocates a new buffer for each record.
If we need changed, `RawWritableDeserializationStream` rename to
`DeepRawWritableDeserializationStream`, and
`SharedRawWritableDeserializationStream` rename to
`ShallowRawWritableDeserializationStream`. How about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
