maobaolong commented on code in PR #2199:
URL:
https://github.com/apache/incubator-uniffle/pull/2199#discussion_r1810607506
##########
storage/src/main/java/org/apache/uniffle/storage/common/AbstractStorage.java:
##########
@@ -44,13 +47,13 @@ public ShuffleWriteHandler
getOrCreateWriteHandler(CreateShuffleWriteHandlerRequ
writerHandlers.computeIfAbsent(request.getAppId(), key ->
JavaUtils.newConcurrentMap());
requests.computeIfAbsent(request.getAppId(), key ->
JavaUtils.newConcurrentMap());
Map<String, ShuffleWriteHandler> map =
writerHandlers.get(request.getAppId());
- String partitionKey =
- RssUtils.generatePartitionKey(
- request.getAppId(), request.getShuffleId(),
request.getStartPartition());
- map.computeIfAbsent(partitionKey, key -> newWriteHandler(request));
+ String partitionKeyExceptAppId =
Review Comment:
Shall we forward a new step to use `int` type and bit `shift` operation to
construct a int type partitionKey?
This can reduce string concat operation and the invoked time of `valueOf`,
so it can reduce jvm objects and save the cpu usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
