jerqi commented on PR #2217: URL: https://github.com/apache/incubator-uniffle/pull/2217#issuecomment-2430767382
> @jerqi Thanks for this remind, after go through the code related to `SHUFFLE_SERVER_VERSION`, I have some primary knowledge about this. > > * SHUFFLE_SERVER_VERSION is used as a tag of server > * Coordinator select the servers for client follow the tag filter from client > * Metrics related > > In conclusion, I guess the motivation of the `SHUFFLE_SERVER_VERSION` aimed to select the same version/tag server for client. String type tag/version make easy to understand version, but hard to extend, if we extend a new feature base on `ss_v5`, old client could not use `ss_v5` as tag to get assignment, even the new feature include `ss_v5` feature. > > But this motivation of `ServiceVersion` is aimed to make client adopt to the servers with different `serviceVersion`, to make them all work NO, if we give uncompatible update, we should change the version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
