jerqi commented on code in PR #2196:
URL:
https://github.com/apache/incubator-uniffle/pull/2196#discussion_r1818284682
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -498,15 +502,23 @@ public void updateCachedBlockIds(
}
ShuffleTaskInfo shuffleTaskInfo =
shuffleTaskInfos.computeIfAbsent(appId, x -> new
ShuffleTaskInfo(appId));
- Roaring64NavigableMap bitmap =
- shuffleTaskInfo
- .getCachedBlockIds()
- .computeIfAbsent(shuffleId, x -> Roaring64NavigableMap.bitmapOf());
-
long size = 0L;
- synchronized (bitmap) {
+ // With memory storage type should never need cachedBlockIds,
+ // since client do not need call finish shuffle rpc
+ if (!shuffleTaskInfo.isClientStorageTypeWithMemory()) {
Review Comment:
Maybe this config option should be same between server and client side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
