zhengchenyu commented on PR #2246: URL: https://github.com/apache/incubator-uniffle/pull/2246#issuecomment-2467618882
Before this PR, The files under META-INF are as follows: ``` xxuser@xxhost tmp % ll META-INF total 96 drwxr-xr-x@ 15 zhengchenyu staff 480 11 9 12:16 ./ drwxr-xr-x@ 10 zhengchenyu staff 320 11 11 17:09 ../ -rw-r--r--@ 1 zhengchenyu staff 22734 11 9 12:16 DEPENDENCIES -rw-r--r--@ 1 zhengchenyu staff 571 11 9 12:16 DISCLAIMER -rw-r--r--@ 1 zhengchenyu staff 104 11 9 12:16 MANIFEST.MF -rw-r--r--@ 1 zhengchenyu staff 11430 11 9 12:16 NOTICE -rw-r--r--@ 1 zhengchenyu staff 439 10 10 2023 io.netty.versions.properties drwxr-xr-x@ 6 zhengchenyu staff 192 5 5 2023 license/ drwxr-xr-x@ 15 zhengchenyu staff 480 11 9 12:15 licenses/ drwxr-xr-x@ 11 zhengchenyu staff 352 11 9 12:15 maven/ drwxr-xr-x@ 16 zhengchenyu staff 512 11 9 12:16 native/ drwxr-xr-x@ 4 zhengchenyu staff 128 2 2 2024 native-image/ drwxr-xr-x@ 10 zhengchenyu staff 320 2 1 1980 proguard/ drwxr-xr-x@ 10 zhengchenyu staff 320 11 9 12:14 services/ drwxr-xr-x@ 4 zhengchenyu staff 128 1 6 2023 versions/ xx user@xx host tmp % ll META-INF/license total 96 drwxr-xr-x@ 6 zhengchenyu staff 192 5 5 2023 ./ drwxr-xr-x@ 15 zhengchenyu staff 480 11 9 12:16 ../ -rw-r--r--@ 1 zhengchenyu staff 6121 5 5 2023 LICENSE.aix-netbsd.txt -rw-r--r--@ 1 zhengchenyu staff 12486 5 5 2023 LICENSE.boringssl.txt -rw-r--r--@ 1 zhengchenyu staff 11358 5 5 2023 LICENSE.mvn-wrapper.txt -rw-r--r--@ 1 zhengchenyu staff 11356 5 5 2023 LICENSE.tomcat-native.txt ``` I can not find LICENSE file in META-INF directory. But I found META-INF/license directory which is from `grpc-netty-shaded-1.61.1.jar.` To be honest, I don't know whether these third-party library needs to be in directory META-INF/licenses, because these third-party are need by `grpc-netty-shaded-1.61.1.jar`. In this pr, these third-party library is ignored. I guess that In some OS where files are not case sensitive. license directory conficts with License file. So License is missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
