zuston commented on code in PR #2253:
URL:
https://github.com/apache/incubator-uniffle/pull/2253#discussion_r1846217884
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/LocalFileWriteHandler.java:
##########
@@ -139,7 +144,8 @@ public synchronized void
write(Collection<ShufflePartitionedBlock> shuffleBlocks
for (ShufflePartitionedBlock block : shuffleBlocks) {
long blockId = block.getBlockId();
long crc = block.getCrc();
- long startOffset = dataWriter.nextOffset();
+ // put storage id to high 8 bits
+ long startOffset =
ShuffleDataSegment.wrapOffset(dataWriter.nextOffset(), storageId);
Review Comment:
This is too rough. If the offset's high 8 bits has used, this will make the
data inconsistent.
And this is also not compatible with the previous shuffle-server/client
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
