maobaolong commented on code in PR #2265:
URL:
https://github.com/apache/incubator-uniffle/pull/2265#discussion_r1859525060
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/DelegationRssShuffleManager.java:
##########
@@ -133,7 +133,10 @@ private boolean tryAccessCluster() {
RssConf rssConf = RssSparkConfig.toRssConf(sparkConf);
List<String> excludeProperties =
rssConf.get(RssClientConf.RSS_CLIENT_REPORT_EXCLUDE_PROPERTIES);
+ List<String> includeProperties =
+ rssConf.get(RssClientConf.RSS_CLIENT_REPORT_INCLUDE_PROPERTIES);
rssConf.getAll().stream()
+ .filter(entry -> includeProperties.isEmpty() ||
includeProperties.contains(entry.getKey()))
Review Comment:
Empty means include all, that means include config is disabled, it reference
what hdfs treat include/excludes datanode list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
