jerqi commented on code in PR #2265:
URL:
https://github.com/apache/incubator-uniffle/pull/2265#discussion_r1866876034
##########
docs/client_guide/client_guide.md:
##########
@@ -60,6 +60,8 @@ The important configuration of client is listed as following.
These configuratio
| <client_type>.rss.client.rpc.netty.maxOrder | 3
| The value of maxOrder for PooledByteBufAllocator
when using gRPC internal Netty on the client-side. This configuration will only
take effect when rss.rpc.server.type is set to GRPC_NETTY.
|
| <client_type>.rss.client.rpc.netty.smallCacheSize | 1024
| The value of smallCacheSize for
PooledByteBufAllocator when using gRPC internal Netty on the client-side. This
configuration will only take effect when rss.rpc.server.type is set to
GRPC_NETTY.
|
| <client_type>.rss.client.blockIdManagerClass | -
| The block id manager class of server for this
application, the implementation of this interface to manage the shuffle block
ids
|
+| <client_type>.rss.client.reportExcludeProperties | -
| the report exclude properties could be configured
by this option
|
Review Comment:
Is the document right about `reportExcludeProperties` and
`reportIncludeProperties`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
