jerqi commented on PR #1849: URL: https://github.com/apache/incubator-uniffle/pull/1849#issuecomment-2519727164
> If I get this correctly: > > before decoding --> `refCnt` is `1` after decoding --> `refCnt` is `1` (keep still) business codes call `release()` --> `refCnt` is `0` > > If you call `retain`, then the process will be: before decoding --> `refCnt` is `1` after decoding --> `refCnt` is `2` (calling `retain()`) business codes call `release()` --> `refCnt` is `1` > > Then, there will be memory leaks. Right? Does the Netty framework will release the ByteBuf after processing the request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
