wForget commented on PR #2283: URL: https://github.com/apache/incubator-uniffle/pull/2283#issuecomment-2533685340
> Nothing will happen, because we bypass the getReader in the DelegationRssShuffleManager, so the acutall getReader invoking will happen in the underlying concrate shuffle manager. But this is an obvious bug, if someone wants to implement custom shuffle manager, he will follow the incorrect examples. I prefer to infer the appropriate shuffle manager from ShuffleHandle rather than overriding the shuffle manager configuration on the dirver side, so that we can implement stage-level fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
