jerqi commented on issue #2082:
URL: 
https://github.com/apache/incubator-uniffle/issues/2082#issuecomment-2540784651

   Maybe we could remove
   ```
       if (readBuffer != null) {
         RssUtils.releaseByteBuffer(readBuffer);
       }
   ```
   Because we have released the ByteBuf
   ```
       if (sdr != null) {
         sdr.release();
         // We set sdr to null here to prevent IllegalReferenceCountException 
that could occur
         // if sdr.release() is called multiple times in the close() method,
         // when an exception is thrown by clientReadHandler.readShuffleData().
         sdr = null;
       }
   ```
   
![image](https://github.com/user-attachments/assets/f091c560-ff09-4cec-a4d0-d461f341434d)
   
   cc @rickyma @maobaolong @leixm WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to