zuston commented on code in PR #2299:
URL:
https://github.com/apache/incubator-uniffle/pull/2299#discussion_r1889532733
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -1198,6 +1198,12 @@ public void getLocalShuffleData(
offset,
length,
storageId);
+ reply =
+ GetLocalShuffleDataResponse.newBuilder()
+ .setStatus(status.toProto())
+ .setRetMsg(msg)
+ .setData(UnsafeByteOperations.unsafeWrap(sdr.getData()))
Review Comment:
the operation of `sdr.getData()` will cost too much time, so it should be
scoped into the metrics recording
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
