cchung100m commented on issue #1912: URL: https://github.com/apache/incubator-uniffle/issues/1912#issuecomment-2577983622
Hi @rickyma Based on my understanding of the description, we need to modify the following part from `sbi.getSize()` to `sbi.getLength()`. Please help to confirm my understanding, thank you. 😄 https://github.com/apache/incubator-uniffle/blob/3ea5c2c780b1cb8cf01e63ecd82b5c2410c2ac49/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriteBufferManager.java#L514 https://github.com/apache/incubator-uniffle/blob/3ea5c2c780b1cb8cf01e63ecd82b5c2410c2ac49/internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java#L555 https://github.com/apache/incubator-uniffle/blob/3ea5c2c780b1cb8cf01e63ecd82b5c2410c2ac49/internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcNettyClient.java#L145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
