jerqi commented on code in PR #2325:
URL:
https://github.com/apache/incubator-uniffle/pull/2325#discussion_r1908074741
##########
integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorReconfigureNodeMaxTest.java:
##########
@@ -132,7 +132,12 @@ public void testReconfigureNodeMax() throws Exception {
// case3: recover its value to 10
// Make sure last modification time change
- Thread.sleep(1000L);
+ File tempConfFile = new File(tempConfFilePath);
+ long currentTime = System.currentTimeMillis();
+ if (currentTime - tempConfFile.lastModified() < 1000) {
+ Thread.sleep(1000 - (currentTime - tempConfFile.lastModified()));
Review Comment:
Could use `Awaitility.await()` instead of `sleep`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
