jerqi commented on code in PR #2331:
URL:
https://github.com/apache/incubator-uniffle/pull/2331#discussion_r1912873703
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/SimpleClusterManagerTest.java:
##########
@@ -451,6 +451,8 @@ public void updateExcludeNodesTest() throws Exception {
remainNodes,
availableNodes.stream().map(ServerNode::getId).collect(Collectors.toSet()));
final Set<String> nodes2 = Sets.newHashSet("node3-1999", "node4-1999");
+ // Make sure last modification time change
+ Thread.sleep(1000);
Review Comment:
Could use Awaitility.await() instead of sleep? We should wait for a
condition instead of a fixed interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
