jerqi commented on code in PR #2363:
URL:
https://github.com/apache/incubator-uniffle/pull/2363#discussion_r1946253113
##########
common/src/main/java/org/apache/uniffle/common/compression/ZstdCodec.java:
##########
@@ -69,7 +76,16 @@ public void decompress(ByteBuffer src, int uncompressedLen,
ByteBuffer dst, int
@Override
public byte[] compress(byte[] src) {
- return Zstd.compress(src, compressionLevel);
+ ZstdCompressCtx ctx = new ZstdCompressCtx();
Review Comment:
One question: Do we need to create Ctx for every time? It will cost time if
ZstdCompressCtx will create and destroy the thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
