LuciferYang commented on code in PR #2379:
URL: 
https://github.com/apache/incubator-uniffle/pull/2379#discussion_r1981275325


##########
integration-test/common/src/test/java/org/apache/uniffle/test/QuorumTest.java:
##########
@@ -101,6 +106,15 @@ public static MockedShuffleServer createServer(int id, 
File tmpDir, int coordina
     return new MockedShuffleServer(shuffleServerConf);
   }
 
+  private Integer generateFakePort(Set<Integer> portExistsSet) {

Review Comment:
   Can a int array of size 5 be directly generated, with values ranging from 1 
to 65535, and ensuring that this array has no intersection with `portExistsSet`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to