LuciferYang commented on code in PR #2413:
URL: https://github.com/apache/uniffle/pull/2413#discussion_r2004820535
##########
client/src/main/java/org/apache/uniffle/client/record/RecordBuffer.java:
##########
@@ -69,7 +69,9 @@ public void sort(Comparator comparator) {
new Comparator<Record>() {
@Override
public int compare(Record o1, Record o2) {
- return comparator.compare(o1.getKey(), o2.getKey());
+ int h1 = (o1 == null) ? 0 : o1.hashCode();
Review Comment:
It seems that the change has disrupted the original semantics of "sort by
record key".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
