SuperMetaStream opened a new pull request, #2430: URL: https://github.com/apache/uniffle/pull/2430
Fixes #2428 This PR improves the robustness of the test `LocalStorageManagerTest.testGetLocalStorageInfo`, which previously failed on certain environments due to incorrect disk type detection (SSD vs HDD). ### What changes were proposed in this pull request? - Improved the logic for detecting disk type via `lsblk` to handle unexpected or missing ROTA values - Silently skipped media type assertion if detection is not reliable, avoiding false failures ### Why are the changes needed? The test is flaky on machines with NVMe SSDs or less common disk setups, where tools like `lsblk` may not return consistent results. This leads to false test failures even when the logic is correct. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually tested the fix on both SSD and HDD environments by running: ```bash mvn test -Dtest=LocalStorageManagerTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
