xianjingfeng commented on code in PR #2456:
URL: https://github.com/apache/uniffle/pull/2456#discussion_r2053707427
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -117,6 +117,8 @@ public class ShuffleTaskManager {
private final ShuffleBufferManager shuffleBufferManager;
private Map<String, ShuffleTaskInfo> shuffleTaskInfos =
JavaUtils.newConcurrentMap();
private Map<Long, PreAllocatedBufferInfo> requireBufferIds =
JavaUtils.newConcurrentMap();
+ private final Map<String, Long> appsWaitingToBeRemoved =
JavaUtils.newConcurrentMap();
Review Comment:
This can be removed. Without this, expired app will be add to
`expiredAppIdQueue` twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
