jerqi commented on code in PR #2492:
URL: https://github.com/apache/uniffle/pull/2492#discussion_r2137379866
##########
common/src/main/java/org/apache/uniffle/common/ShufflePartitionedBlock.java:
##########
@@ -76,15 +80,12 @@ public boolean equals(Object o) {
return false;
}
ShufflePartitionedBlock that = (ShufflePartitionedBlock) o;
- return dataLength == that.dataLength
- && crc == that.crc
- && blockId == that.blockId
- && data.equals(that.data);
Review Comment:
If we don't have special reason, we should use the common ways. If you have
other special reasons, we should add comment to tell others this is not wrong
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
