zhengchenyu commented on code in PR #2607:
URL: https://github.com/apache/uniffle/pull/2607#discussion_r2343508582
##########
client-mr/core/src/main/java/org/apache/hadoop/mapred/RssMapOutputCollector.java:
##########
@@ -78,12 +78,31 @@ public void init(Context context) throws IOException,
ClassNotFoundException {
throw new IOException("Invalid sort memory use threshold : " +
sortThreshold);
}
- // combiner
- final Counters.Counter combineInputCounter =
- reporter.getCounter(TaskCounter.COMBINE_INPUT_RECORDS);
- combinerRunner =
- Task.CombinerRunner.create(
- mrJobConf, mapTask.getTaskID(), combineInputCounter, reporter,
null);
+ boolean enableCombiner =
+ RssMRUtils.getBoolean(
+ rssJobConf,
+ RssMRConfig.RSS_CLIENT_COMBINER_ENABLE,
+ RssMRConfig.RSS_CLIENT_COMBINER_ENABLE_DEFAULT);
+
+ combinerRunner = null;
+ if (enableCombiner) {
+ try {
+ if (mrJobConf.getCombinerClass() != null ||
Review Comment:
I means that can we check the return value of Task.CombinerRunner.create,
but not use `con.get(xxx) != null`?
Although these configurations are unlikely to change, it is better to ensure
that they are independent of the configuration through the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org
For additional commands, e-mail: issues-h...@uniffle.apache.org
